Re: [PATCH 09/11] MIPS: mobileye: Add EPM5 device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


"Arnd Bergmann" <arnd@xxxxxxxx> writes:

> On Wed, Oct 4, 2023, at 18:10, Gregory CLEMENT wrote:
>> +
>> +	chosen {
>> +		bootargs = "cca=5 earlycon console=ttyAMA2 ddr32_alias=0x40000000";
>> +		stdout-path = "serial2:115200n8";
>> +	};
>> +
> The bootargs should not be needed here, at least most of them:
> - no need to set both console= and the stdout-path if you have
>   earlycon support

OK I keep stdout-path.

> - ddr32_alias=0x40000000 sounds like something that should be
>   part of the dtb elsewhere and not require a command line argument.
>   I assume this is needed to even build?

I will answer on the other email but in short I agree.
> - For cca=, it looks like this is intended to be autodetected from
>   the c0_config register. Does that not work for you for some reason?

Indeed I checked and it it nost needed anymore, it is already set in
cps_smp_setup. I remove it.



>      Arnd

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering

[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux