On Thu, Jun 22, 2023 at 5:56 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> Clang warns:
>
> drivers/clk/ralink/clk-mtmips.c:309:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> 309 | return ret;
> | ^~~
> drivers/clk/ralink/clk-mtmips.c:285:9: note: initialize the variable 'ret' to silence this warning
> 285 | int ret, i;
> | ^
> | = 0
> drivers/clk/ralink/clk-mtmips.c:359:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> 359 | return ret;
> | ^~~
> drivers/clk/ralink/clk-mtmips.c:335:9: note: initialize the variable 'ret' to silence this warning
> 335 | int ret, i;
> | ^
> | = 0
> 2 errors generated.
>
> Set ret to the return value of clk_hw_register_fixed_rate() using the
> PTR_ERR() macro, which ensures ret is not used uninitialized, clearing
> up the warning.
>
> Fixes: 6f3b15586eef ("clk: ralink: add clock and reset driver for MTMIPS SoCs")
> Closes: https://github.com/ClangBuiltLinux/linux/issues/1879
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> drivers/clk/ralink/clk-mtmips.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks for the patch, Nathan!!
Acked-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
Best regards,
Sergio Paracuellos
