On Tue, May 16, 2023 at 09:39:42PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The unxlate_dev_mem_ptr() function has no prototype on the mips > architecture, which does not include asm-generic/io.h, so gcc warns > about the __weak definition: > > drivers/char/mem.c:94:29: error: no previous prototype for 'unxlate_dev_mem_ptr' [-Werror=missing-prototypes] > > Since everyone else already gets the generic definition or has a custom > one, there is not really much point in having a __weak version as well. > > Remove this one, and instead add a trivial macro to the mips header. > Once we convert mips to use the asm-generic header, this can go away > again. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > arch/mips/include/asm/io.h | 1 + > drivers/char/mem.c | 7 ------- > 2 files changed, 1 insertion(+), 7 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
