On 13/12/2022 14:04, Arınç ÜNAL wrote: > Not every function can be muxed to a group. Add proper binding which > documents which function can be muxed to a group or set of groups. > > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > --- > .../pinctrl/ralink,mt7621-pinctrl.yaml | 204 +++++++++++++++++- > 1 file changed, 197 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml > index 61e5c847e8c8..0efb03f1d88e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml > @@ -29,21 +29,212 @@ patternProperties: > $ref: pinmux-node.yaml# > > properties: > - groups: > - description: The pin group to select. > - enum: [i2c, jtag, mdio, pcie, rgmii1, rgmii2, sdhci, spi, uart1, > - uart2, uart3, wdt] > - > function: > - description: The mux function to select. > + description: > + A string containing the name of the function to mux to the group. > enum: [gpio, i2c, i2s, jtag, mdio, nand1, nand2, pcie refclk, > pcie rst, pcm, rgmii1, rgmii2, sdhci, spdif2, spdif3, spi, > uart1, uart2, uart3, wdt refclk, wdt rst] > > + groups: > + description: > + An array of strings. Each string contains the name of a group. Here and in all patches - please add maxItems:1. The definition of field should have some constraints (and your if:then: might miss a case). Best regards, Krzysztof
