On 14/12/2022 14:03, Arınç ÜNAL wrote: > On 14.12.2022 14:55, Krzysztof Kozlowski wrote: >>> >>> + allOf: >>> + - if: >>> + properties: >>> + function: >>> + const: antenna >>> + then: >>> + properties: >>> + groups: >>> + enum: [i2s] >> >> I have doubts such setup is maintainable and readable. I would suggest >> to leave just few - maybe for gpio, jtag, refclk, utif. > > These bindings are not going to change once all properly defined and I'm > here as a maintainer so I don't see an issue with maintaining the binding. > > It's the whole pin configuration of an SoC squashed under a single > document. I guess this is the fate of the pinctrl bindings. The bindings > for mt7622 is not so different: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/pinctrl/mediatek%2Cmt7622-pinctrl.yaml#n63 It's much smaller number of if:then: than yours but if you want to manage it then sure: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
