On Wed, 14 Sep 2022, Dmitry Grinberg wrote: > The comment is correct, the code is missing a single "0" to be correct. As > is only 30MB of memory will be probed. Thank you for your submission. Technically you are correct, although in reality PMAX machines only have up to 24MiB of RAM, so this bug won't ever trigger. This would only matter for early 3MAX machines, before the ROM upgrade to the REX standard. I would expect all the existing machines to have been converted by now. I guess your patch can be accepted anyway, however there are a couple of issues with it as below. > commit 91aa935a527d88e8fd5f40acd271164a3e8f1ae7 > Author: Dmitry Grinberg <dmitrygr@xxxxxxxxx> > Date: Tue Aug 30 01:25:29 2022 -0500 > > fix pmax memory limit to match comment Please capitalise the change heading and prefix it with the name of the subsystem(s) involved, e.g.: MIPS: DEC: Fix pmax memory limit to match comment Please add a change description, e.g by reusing the text you have used for the introduction, and add a `Signed-off-by' tag, as per `Documentation/process/submitting-patches.rst'. Verify your change by running it through `scripts/checkpatch.pl', e.g.: $ git format-patch --stdout 91aa935a527d^- | scripts/checkpatch.pl Please make your submission the sole contents of the e-mail. If your mailer restricts you in some way, then use `git send-email'. Last but not least please send your submission to the correct MIPS/Linux mailing list, which now is <linux-mips@xxxxxxxxxxxxxxx>, and also cc the general Linux kernel mailing list at <linux-kernel@xxxxxxxxxxxxxxx>. You can get the expected list of recipients with `scripts/get_maintainer.pl', e.g.: $ git format-patch --stdout 91aa935a527d^- | scripts/get_maintainer.pl Please let me know if you find anything I wrote unclear or need further guidance. Thanks, Maciej
