Maciej W. Rozycki <macro@xxxxxxxxxxx> 于2022年4月29日周五 23:11写道： > > Additionally I've thought of adding something like: > > #if cpu_has_fpu > # undef cpu_has_fpu > #endif > > or maybe even: > > #if cpu_has_fpu > # error "Forcing `cpu_has_fpu' to non-zero is not supported" > #endif > > to arch/mips/include/asm/cpu-features.h, but maybe that's an overkill. > > Maciej Yeah, but why do you think that's an overkill? There is a great chance people will ignore the note of 'cpu_has_fpu', and it did happen. When that happens, there should exist a way to point out or fix that. Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> 于2022年4月29日周五 18:01写道： > > I prefer just removing the #defines from ip27/ip30 cpu-feasture-overrides.h. > Or isn't that enough for fixing the problem ? > > Thomas. So maybe that's why I don't think just removing the #defines from ip27/ip30 cpu-feasture-overrides.h. is enough for fixing the problem. Stephen.
