On Fri, 29 Apr 2022, Thomas Bogendoerfer wrote: > > diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h > > index de8cb2ccb781..38eb469008b6 100644 > > --- a/arch/mips/include/asm/cpu-features.h > > +++ b/arch/mips/include/asm/cpu-features.h > > @@ -134,6 +134,10 @@ > > # endif > > #else > > # define raw_cpu_has_fpu cpu_has_fpu > > +# ifndef CONFIG_MIPS_FP_SUPPORT > > +# undef cpu_has_fpu > > +# define cpu_has_fpu 0 > > +# endif > > #endif > > #ifndef cpu_has_32fpr > > #define cpu_has_32fpr __isa_ge_or_opt(1, MIPS_CPU_32FPR) > > -- > > 2.30.2 > > I prefer just removing the #defines from ip27/ip30 cpu-feasture-overrides.h. > Or isn't that enough for fixing the problem ? That's what I've meant, and I have now posted fixes, successfully build-tested. Additionally I've thought of adding something like: #if cpu_has_fpu # undef cpu_has_fpu #endif or maybe even: #if cpu_has_fpu # error "Forcing `cpu_has_fpu' to non-zero is not supported" #endif to arch/mips/include/asm/cpu-features.h, but maybe that's an overkill. Maciej
