Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on 150866cd0ec871c765181d145aa0912628289c8a] url: https://github.com/intel-lab-lkp/linux/commits/David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 base: 150866cd0ec871c765181d145aa0912628289c8a config: riscv-randconfig-r005-20220422 (https://download.01.org/0day-ci/archive/20220423/202204231516.bclimUe4-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/871c5afc76a6f414c03f433d06bacfd928910b1b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 git checkout 871c5afc76a6f414c03f433d06bacfd928910b1b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): arch/riscv/kvm/mmu.c: In function 'stage2_ioremap': >> arch/riscv/kvm/mmu.c:364:56: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 364 | ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); | ^ arch/riscv/kvm/mmu.c:369:52: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 369 | ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); | ^ arch/riscv/kvm/mmu.c:378:41: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 378 | kvm_mmu_free_memory_cache(&cache.cache); | ^ >> arch/riscv/kvm/mmu.c:350:37: warning: variable 'cache' set but not used [-Wunused-but-set-variable] 350 | struct kvm_mmu_memory_cache cache = { | ^~~~~ vim +364 arch/riscv/kvm/mmu.c 342 343 static int stage2_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, 344 unsigned long size, bool writable) 345 { 346 pte_t pte; 347 int ret = 0; 348 unsigned long pfn; 349 phys_addr_t addr, end; > 350 struct kvm_mmu_memory_cache cache = { 351 .capacity = KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE, 352 .gfp_zero = __GFP_ZERO, 353 }; 354 355 end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; 356 pfn = __phys_to_pfn(hpa); 357 358 for (addr = gpa; addr < end; addr += PAGE_SIZE) { 359 pte = pfn_pte(pfn, PAGE_KERNEL); 360 361 if (!writable) 362 pte = pte_wrprotect(pte); 363 > 364 ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); 365 if (ret) 366 goto out; 367 368 spin_lock(&kvm->mmu_lock); 369 ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); 370 spin_unlock(&kvm->mmu_lock); 371 if (ret) 372 goto out; 373 374 pfn++; 375 } 376 377 out: 378 kvm_mmu_free_memory_cache(&cache.cache); 379 return ret; 380 } 381 -- 0-DAY CI Kernel Test Service https://01.org/lkp
