Re: [PATCH] MIPS: rb532: move GPIOD definition into C-files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 30, 2022 at 12:56 PM Jackie Liu <liu.yun@xxxxxxxxx> wrote:
> 在 2022/3/30 下午5:41, Andy Shevchenko 写道:
> > On Wed, Mar 30, 2022 at 12:32 PM Thomas Bogendoerfer
> > <tsbogend@xxxxxxxxxxxxxxxx> wrote:

...

> > It fixes compilation breakage in some cases. I think the author of
> > this patch can (should) elaborate.
> > Also, it might need a Fixes tag.
>
> Um, it's really hard to say which commit is fixed, just because this
> header file defines a GPIOD, and someone else uses this later.

I think we may use the original commit where the header in mips
appeared with a justification that the definitions are not needed to
be there and it may induce build errors, which in fact happens.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux