On Wed, Mar 30, 2022 at 09:46:07AM +0800, Jackie Liu wrote: > > > 在 2022/3/29 下午8:54, Andy Shevchenko 写道: > > On Tue, Mar 29, 2022 at 4:46 AM Jackie Liu <liu.yun@xxxxxxxxx> wrote: > > > > > > From: Jackie Liu <liuyun01@xxxxxxxxxx> > > > > > > My kernel robot report build error from drivers/iio/adc/da9150-gpadc.c, > > > > > > We define GPIOD in rb.h, in fact he should only be used in gpio.c, but > > > > he --> it > > > > > it affects the driver da9150-gpadc.c which goes against the original > > > intention of the design, just move it to his scope. > > > > > At the same time, GPIONMIEN and IMASK6 are not used anywhere, just delete > > > them. > > > > While not being used it's good to leave (save) them since it might be > > the only means of the HW documentation. I know that Git history will > > keep that, but it is more explicit just to have them in the code. > > Sure. > > > > > ... > > > > > #define DEV3TC 0x01003C > > > #define BTCS 0x010040 > > > #define BTCOMPARE 0x010044 > > > -#define GPIOBASE 0x050000 > > > > ... > > > > > +#define GPIOBASE 0x050000 > > > > I think this one belongs to the header. > > I think it would be better to put it in gpio.c, after all it belongs to > the GPIO module and is not used elsewhere. It doesn't feel good if we > put it in the header file. I have a patchset, where the both files will go away. No need to clean up now. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
