Hi! On 28/01/2021 12:35, Peter Zijlstra wrote: >> My point was that original MIPS spinlocks had this write-buffer-flush and >> it got lost on the conversion to qspinlocks. The referenced commit just >> allows to see the last MIPS-specific implementation before deletion. > Hardware that needs a store-buffer flush after release is highly suspect > and needs big and explicit comments. Not vague hints. I have a feeling that you are not going to suggest the comments for the code and one has to guess what is it you have in mind? Do you think the proper approach would be to undelete MIPS spinlocks and make these broken qspinlocks a configurable option for MIPS? I don't even mind if they will be default option for those not interested in performance or latency. -- Best regards, Alexander Sverdlin.
