On Mon, Aug 31, 2020 at 11:07:33PM +0200, Thomas Bogendoerfer wrote:
> On Mon, Aug 31, 2020 at 10:01:45AM +0800, Huang Pei wrote:
> > In cc97ab235f3fe32401ca198cebe6f42642e95770, init_fp_ctx just initialize the
>
> checkpatch will warn you about this:
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #7:
> In cc97ab235f3fe32401ca198cebe6f42642e95770, init_fp_ctx just initialize the
>
> Use cc97ab235f3f ("MIPS: Simplify FP context initialization") instead of
> the pure hash.
>
>
> > fp/msa context, and own_fp_inatomic just restore FCSR and 64bit FP regs from
> > it, but miss MSACSR and upper MSA regs for MSA, so MSACSR and MSA upper regs's
> > value from previous task on current cpu can leak into current task and cause
> > unpredictable behavior when MSA context not initialized.
>
> And add
>
> Fixes: cc97ab235f3f ("MIPS: Simplify FP context initialization")
>
> before your Signed-off-by, which is what I meant with "add fixes tag".
>
> >
> > Signed-off-by: Huang Pei <huangpei@xxxxxxxxxxx>
> > ---
> > arch/mips/kernel/traps.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
Thank you for your time, I will reread submitting-patches.rst and
recheck all my patches
