Re: [PATCH] MIPS: add missing MSACSR and upper MSA initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 28, 2020 at 09:41:18AM +0200, Thomas Bogendoerfer wrote:
> On Thu, Aug 27, 2020 at 07:41:31PM +0800, Huang Pei wrote:
> > On Wed, Aug 26, 2020 at 04:17:43PM +0300, Sergei Shtylyov wrote:
> > 
> > >From 218f23077352a7befd2aaad3fa46b93112d4051b Mon Sep 17 00:00:00 2001
> > From: Huang Pei <huangpei@xxxxxxxxxxx>
> > Date: Fri, 21 Aug 2020 10:48:40 +0800
> > Subject: [PATCH] MIPS: add missing MSACSR and upper MSA initialization
> > 
> > init_fp_ctx just initialize the fp/msa context, and own_fp_inatomic
> > just restore FCSR and 64bit FP regs from it, but miss MSACSR and upper
> > MSA regs for MSA, so MSACSR and MSA upper regs's value from previous
> > task on current cpu can leak into current task and cause unpredictable
> > behavior when MSA context not initialized.
> > 
> > Signed-off-by: Huang Pei <huangpei@xxxxxxxxxxx>
> 
> Please submit in a new email and not in respone to another mail, and
> add a Fixes tag.  Otherwise the fix looks correct to me. Thank you.
> 
> Thomas.
> 
> -- 
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]

Got it, send this patch alone in a new mail

Huang Pei,




[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux