Hello Mauro, On Mon, Mar 28, 2016 at 2:11 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> wrote: > Add a note at the headers telling that the link setup > callbacks are called with the mutex hold. Also, removes a > double lock at the PM suspend callbacks. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > --- > drivers/media/media-device.c | 1 - > drivers/media/v4l2-core/v4l2-mc.c | 4 ---- > include/media/media-device.h | 3 ++- > include/media/media-entity.h | 3 +++ > 4 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > index 6cfa890af7b4..6af5e6932271 100644 > --- a/drivers/media/media-device.c > +++ b/drivers/media/media-device.c > @@ -93,7 +93,6 @@ static struct media_entity *find_entity(struct media_device *mdev, u32 id) > media_device_for_each_entity(entity, mdev) { > if (((media_entity_id(entity) == id) && !next) || > ((media_entity_id(entity) > id) && next)) { > - mutex_unlock(&mdev->graph_mutex); This change belongs to patch 1/2. After this change, feel free to add to both patches: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html