Hi Junghak,
On 22-09-15 15:30, Junghak Sung wrote:
> Replace struct v4l2_format * with vb2_format * to make queue_setup()
> for common use.
>
> struct vb2_format {
> unsigned int type;
> unsigned int pixelformat;
> unsigned int width;
> unsigned int height;
> unsigned int num_planes;
> unsigned int bytesperline[VIDEO_MAX_PLANES];
> unsigned int req_sizes[VIDEO_MAX_PLANES];
> };
Why would you need all the other fields besides req_sizes[]?
Which drivers actually need those other fields? Drivers like exynos4-is/fimc-lite.c
don't actually use anything but req_sizes if you read the code carefully.
I suspect any driver that uses more than req_sizes is actually buggy or
written carelessly.
I wish you'd checked with me before making this struct...
Be aware that I'm abroad (vacation/conferences) from tomorrow until October 10,
so I won't be able to do in-depth reviews during that time (well, I'm able,
but I don't want to!)
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
