Em Tue, 25 Aug 2015 16:32:19 -0600 Shuah Khan <shuahkhan@xxxxxxxxx> escreveu: > On Tue, Aug 25, 2015 at 4:10 AM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxxxxxxx> wrote: > > Em Tue, 25 Aug 2015 09:10:57 +0200 > > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > > > >> On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > >> > This code is not used in practice. Get rid of it before > >> > start converting links to lists. > >> > >> I assume the reason is that links are always created *after* > >> entities are registered? > > > > That was the assumption. However, Javier found some cases where drivers > > are creating links before. > > > > So, we should either drop this patch and add some additional logic > > on the next one to handle late graph object init or to fix the > > drivers before. > > > > I'll work on the delayed graph object init, as it sounds the > > easiest way, but let's see how such change will actually work. > > > > I think we should drop this patch for now. We can't, as otherwise it will break compilation on patch 16/44. What we need to do is to ensure that all drivers will be doing the right thing before this one. > I also would like to see > this new code > in action on a driver that has DVB and V4L modules and creates entities during > probe and maybe even links during probe with no specific probe ordering between > individual module probes. This way we are sure we need this code and know that > it is correct. See media-ctl --print-t output: http://pastebin.com/ckxafiJB Please notice that the media-ctl version I'm using doesn't know the DVB entity types yet, as it needs to be patched to be aware of the new API. So, it reports the DVB stuff as "unknow entities". And that's the output of the new tool that uses the new API: http://pastebin.com/fRhMcTue Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
