Em Tue, 25 Aug 2015 09:10:57 +0200 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > > This code is not used in practice. Get rid of it before > > start converting links to lists. > > I assume the reason is that links are always created *after* > entities are registered? That was the assumption. However, Javier found some cases where drivers are creating links before. So, we should either drop this patch and add some additional logic on the next one to handle late graph object init or to fix the drivers before. I'll work on the delayed graph object init, as it sounds the easiest way, but let's see how such change will actually work. > > Can you add that to this commit log? > > With that change: > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > > > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > > index 138b18416460..0d85c6c28004 100644 > > --- a/drivers/media/media-device.c > > +++ b/drivers/media/media-device.c > > @@ -443,13 +443,6 @@ int __must_check media_device_register_entity(struct media_device *mdev, > > media_gobj_init(mdev, MEDIA_GRAPH_ENTITY, &entity->graph_obj); > > list_add_tail(&entity->list, &mdev->entities); > > > > - /* > > - * Initialize objects at the links > > - * in the case where links got created before entity register > > - */ > > - for (i = 0; i < entity->num_links; i++) > > - media_gobj_init(mdev, MEDIA_GRAPH_LINK, > > - &entity->links[i].graph_obj); > > /* Initialize objects at the pads */ > > for (i = 0; i < entity->num_pads; i++) > > media_gobj_init(mdev, MEDIA_GRAPH_PAD, > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
