Hi William,
Just a nitpick:
On Wed, 20 May 2015, William Towle wrote:
> Add support for the ADV7612 chip as implemented on Renesas' Lager
> board to adv7604.c, including lists for formats/colourspace/timing
> selection and an IRQ handler.
>
> Signed-off-by: William Towle <william.towle@xxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/adv7604.c | 83 +++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 81 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index be3f866..a2abb04 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
[snip]
> @@ -2805,8 +2883,9 @@ static int adv76xx_probe(struct i2c_client *client,
> } else {
> val = (adv_smbus_read_byte_data_check(client, 0xea, false) << 8)
> | (adv_smbus_read_byte_data_check(client, 0xeb, false) << 0);
> - if (val != 0x2051) {
> - v4l2_info(sd, "not an adv7611 on address 0x%x\n",
> + if ((state->info->type == ADV7611 && val != 0x2051) ||
> + (state->info->type == ADV7612 && val != 0x2041)) {
> + v4l2_info(sd, "not an adv761x on address 0x%x\n",
A switch / case might look slightly better here.
Thanks
Guennadi
> client->addr << 1);
> return -ENODEV;
> }
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
