> +struct aat1290_led_config_data { > + /* maximum LED current in movie mode */ > + u32 max_mm_current; > + /* maximum LED current in flash mode */ > + u32 max_flash_current; > + /* maximum flash timeout */ > + u32 max_flash_tm; Ok, the comments tell us what should be already obvious from the variable names... but it would be nice to add units. (mA? uA? msec?) (I guess in subsequent patch). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html