On Wed, 29 Apr 2015 20:05:53 -0300 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> wrote: > ov7670_s_exp() checks read error for 2 registers: REG_COM1 > and REG_COM8. But, although it uses the value latter, it > doesn't check errors on REG_AECHH read. Yet, as it is doing > a bitmask operation there, the read operation should succeed. > > So, fix the code to also check if this succeeded. > > This fixes this smatch report: > drivers/media/i2c/ov7670.c:1366 ov7670_s_exp() warn: inconsistent indenting That's why I like programming in Python...:) Silly mistake, good fix. Acked-by: Jonathan Corbet <corbet@xxxxxxx> jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
