Hi Laurent, On Tue, Apr 07, 2015 at 01:10:20PM +0300, Laurent Pinchart wrote: > > @@ -3022,34 +3026,30 @@ static struct smiapp_platform_data > > *smiapp_get_pdata(struct device *dev) dev_dbg(dev, "reset %d, nvm %d, clk > > %d, csi %d\n", pdata->xshutdown, pdata->nvm_size, pdata->ext_clk, > > pdata->csi_signalling_mode); > > > > - rval = of_get_property(ep, "link-frequencies", &asize) ? 0 : -ENOENT; > > - if (rval) { > > - dev_warn(dev, "can't get link-frequencies array size\n"); > > + if (!bus_cfg->nr_of_link_frequencies) { > > Now that I see it being used, nr_of_link_frequencies feels a bit long. > num_link_freqs could be an alternative. I'll let you decide. But for this > patch, It's long, I agree, but still used in only a small number of places in drivers. I'd prefer to keep it as-is also as the name matches the name of the property. > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html