Hi Laurent,
On Tue, Apr 07, 2015 at 01:02:31PM +0300, Laurent Pinchart wrote:
> Hello Sakari,
>
> Thank you for the patch.
Thanks for the review!
> On Tuesday 07 April 2015 01:57:31 Sakari Ailus wrote:
> > +/*
> > + * v4l2_of_free_endpoint() - release resources acquired by
> > + * v4l2_of_alloc_parse_endpoint()
>
> I would say "free the endpoint allocated by v4l2_of_alloc_parse_endpoint()".
>
> > + * @endpoint - the endpoint the resources of which are to be released
> > + *
> > + * It is safe to call this function with NULL argument or on and
>
> s/and/an/
Fixed both.
> > + * endpoint the parsing of which failed.
> > + */
> > +void v4l2_of_free_endpoint(struct v4l2_of_endpoint *endpoint)
> > +{
> > + if (IS_ERR_OR_NULL(endpoint))
> > + return;
> > +
> > + kfree(endpoint->link_frequencies);
> > + kfree(endpoint);
> > +}
> > +EXPORT_SYMBOL(v4l2_of_free_endpoint);
> > +
> > +/**
> > + * v4l2_of_alloc_parse_endpoint() - parse all endpoint node properties
> > + * @node: pointer to endpoint device_node
> > + *
> > + * All properties are optional. If none are found, we don't set any flags.
> > + * This means the port has a static configuration and no properties have
> > + * to be specified explicitly.
> > + * If any properties that identify the bus as parallel are found and
> > + * slave-mode isn't set, we set V4L2_MBUS_MASTER. Similarly, if we
> > recognise
> > + * the bus as serial CSI-2 and clock-noncontinuous isn't set, we set the
> > + * V4L2_MBUS_CSI2_CONTINUOUS_CLOCK flag.
> > + * The caller should hold a reference to @node.
> > + *
> > + * v4l2_of_alloc_parse_endpoint() has two important differences to
> > + * v4l2_of_parse_endpoint():
> > + *
> > + * 1. It also parses variable size data and
> > + *
> > + * 2. The memory resources it has acquired to store the variable size
> > + * data must be released using v4l2_of_free_endpoint() when no longer
> > + * needed.
>
> I would s/resources it has acquired/it has allocated/ and s/released/freed/.
Fixed.
> Apart from that,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks!
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
