On 22.12.2014 14:25, Mauro Carvalho Chehab wrote: > Em Sun, 21 Dec 2014 21:07:02 +0100 > Matthias Schwarzott <zzam@xxxxxxxxxx> escreveu: > >> Hi! >> >> Should the commit message directly point to the breaking commit >> 36efec48e2e6016e05364906720a0ec350a5d768? > > Yes, if this fixes an issue that happened on a previous commit, then > you should add the original commit there. > > That likely means that this is a regression fix, right? So, you should > c/c the patch to stable, adding a comment msg telling to what Kernel > version it applies (assuming that the patch was merged on 3.18). > Also, please add "PATCH FIX" to the subject, as this patch should be > sent to 3.19 as well. > >> >> This commit hopefully reverts the problematic attach for the Starburst >> card. I kept the GPIO-part in common, but I can split this also if >> necessary. > > Keep the GPIO part in common is better, if the GPIOs are the same. Hi! The GPIO-Pins that are used are the same on both cards. And I assume the ones that control Si2165 on HVR-5500 are just unused on Starburst, so setting them does not hurt (and Antti confirmed that the patch works). The cards have more in common, but I could not find a clean way to share attaching and TS-config of the DVB-S2 frontend. So I will change the commit message, prefix subject with PATCH fix, and resend the patch here and c/c to stable. Regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
