Re: [PATCHv2 1/2] regmap: add configurable lock class key for lockdep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 22, 2014 at 02:55:23PM +0200, Antti Palosaari wrote:
> On 12/22/2014 02:44 PM, Mark Brown wrote:
> >On Sun, Dec 21, 2014 at 12:34:51AM +0200, Antti Palosaari wrote:

> >>I2C client and I2C adapter are using regmap. As a solution, add
> >>configuration option to pass custom lock class key for lockdep
> >>validator.

> >Why is this configurable, how would a device know if the system it is in
> >needs a custom locking class and can safely use one?

> If RegMap instance is bus master, eg. I2C adapter, then you should define
> own custom key. If you don't define own key and there will be slave on that
> bus which uses RegMap too, there will be recursive locking from a lockdep
> point of view.

That doesn't really explain to me why this is configurable, why should
drivers have to worry about this?

Please also write technical terms like regmap normally.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux