On 12/08/2014 12:38 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Thursday 04 December 2014 10:54:56 Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> These drivers depend on VIDEO_V4L2_SUBDEV_API, which in turn >> depends on MEDIA_CONTROLLER. So it is sufficient to just depend >> on VIDEO_V4L2_SUBDEV_API. > > Shouldn't the VIDEO_V4L2_SUBDEV_API dependency be dropped from those (and > other) subdev drivers ? They don't require the userspace API, just the kernel > part. They set V4L2_SUBDEV_FL_HAS_DEVNODE and use v4l2_subdev_get_try_format, so they do need VIDEO_V4L2_SUBDEV_API. Or am I missing something? Regards, Hans > >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> --- >> drivers/media/i2c/Kconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig >> index f40b4cf..29276fd 100644 >> --- a/drivers/media/i2c/Kconfig >> +++ b/drivers/media/i2c/Kconfig >> @@ -196,7 +196,7 @@ config VIDEO_ADV7183 >> >> config VIDEO_ADV7604 >> tristate "Analog Devices ADV7604 decoder" >> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER >> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API >> ---help--- >> Support for the Analog Devices ADV7604 video decoder. >> >> @@ -208,7 +208,7 @@ config VIDEO_ADV7604 >> >> config VIDEO_ADV7842 >> tristate "Analog Devices ADV7842 decoder" >> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER >> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API >> ---help--- >> Support for the Analog Devices ADV7842 video decoder. >> >> @@ -431,7 +431,7 @@ config VIDEO_ADV7393 >> >> config VIDEO_ADV7511 >> tristate "Analog Devices ADV7511 encoder" >> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER >> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API >> ---help--- >> Support for the Analog Devices ADV7511 video encoder. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
