On 12/18/2014 11:08 PM, Guennadi Liakhovetski wrote:
> Hi Hans,
>
> On Thu, 4 Dec 2014, Hans Verkuil wrote:
>
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> Weird, this op isn't used at all. Seems to be orphaned code.
>> Remove it.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> ---
>> include/media/v4l2-subdev.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
>> index b052184..5beeb87 100644
>> --- a/include/media/v4l2-subdev.h
>> +++ b/include/media/v4l2-subdev.h
>> @@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
>> struct v4l2_dv_timings *timings);
>> int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
>> u32 *code);
>> - int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
>> - struct v4l2_frmsizeenum *fsize);
>
> After so many cheerful acks I feel a bit bluffed, but... Your subject says
> "drop enum_mbus_fmt" and your patch drops enum_mbus_fsizes... What am I
> missing??
Oops. Obviously the function name in the subject is wrong.
Interesting that everyone (except you!) just read over that :-)
Regards,
Hans
>
> Thanks
> Guennadi
>
>> int (*g_mbus_fmt)(struct v4l2_subdev *sd,
>> struct v4l2_mbus_framefmt *fmt);
>> int (*try_mbus_fmt)(struct v4l2_subdev *sd,
>> --
>> 2.1.3
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
