On 12/08/2014 07:52 PM, Antti Palosaari wrote:
On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
Increase si2168 cmd execute timeout to prevent firmware load failures.
Tests
shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'
firmware.
Increase timeout to a safe value of 70ms.
Signed-off-by: Jurgen Kramer <gtmkramer@xxxxxxxxx>
Reviewed-by: Antti Palosaari <crope@xxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v3.17+
Cc: <stable@xxxxxxxxxxxxxxx> # v3.16+
Changed from stable 3.17+ to 3.16+ as I found that PCTV 292e timeouts
too when tuning DVB-T2, not always, but from time to time...
Antti
That must go stable 3.17.
Antti
---
drivers/media/dvb-frontends/si2168.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si2168.c
b/drivers/media/dvb-frontends/si2168.c
index ce9ab44..d2f1a3e 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s,
struct si2168_cmd *cmd)
if (cmd->rlen) {
/* wait cmd execution terminate */
- #define TIMEOUT 50
+ #define TIMEOUT 70
timeout = jiffies + msecs_to_jiffies(TIMEOUT);
while (!time_after(jiffies, timeout)) {
ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html