On 12/13/2014 01:12 PM, Benjamin Larsson wrote:
On 12/13/2014 05:15 AM, Antti Palosaari wrote:
On 12/13/2014 02:18 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson <benjamin@xxxxxxxxxxxx>
Reviewed-by: Antti Palosaari <crope@xxxxxx>
Even I could accept that, as a staging driver, I see there some issues:
* missing commit message (ok, it is trivial and patch subject says)
* it is legacy DVBv3 API BER reporting, whilst driver is DVBv5 mostly
due to DVB-T2... So DVBv5 statistics are preferred.
* dynamic debugs has unneded __func__, see
Documentation/dynamic-debug-howto.txt
* there should be spaces used around binary and ternary calculation
operators, see Documentation/CodingStyle for more info how it should be.
Could you read overall these two docs before make new patches:
Documentation/CodingStyle
Documentation/dynamic-debug-howto.txt
also use scripts/checkpatch.pl to verify patch, like that
git diff | ./scripts/checkpatch.pl -
regards
Antti
I will read those. Can you recommend a driver as template for DVBv5
statistics ?
I just posted set of rtl2830 driver patches where is one example.
Another example is af9035 and si2168. DVBv5 stats works so that you
periodically update values in property cache, which are then returned to
application if app request. Values are updated to cache even none is
using those.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
