Re: [PATCH 2/2] mn88472: fix firmware loading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Moikka!

On 12/08/2014 01:12 PM, Benjamin Larsson wrote:
On 12/07/2014 11:36 PM, Antti Palosaari wrote:
On 12/08/2014 12:10 AM, Benjamin Larsson wrote:
The firmware must be loaded one byte at a time via the 0xf6 register.

I don't think so. Currently it downloads firmware in 22 byte chunks
and it seems to work, at least for me, both mn88472 and mn88473.

With both these changes I get much better sensitivity. So something is
better then before. I will track down the needed changes and respin the
patches.

I suspect it is that initialization of all registers which has something to do with sensitivity. I haven't tested if firmware uploading is critical, what happens when some byte is skipped or so...

Did you saw there is config parameter i2c_wr_max? Setting it to '1' does same what that your patch did, but leaves amount of max I2C bytes configurable...

Anyhow, good finding, which needs to be track down.

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux