Re: [RFCv6 PATCH 08/16] vb2-vmalloc: add support for dmabuf exports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/18/14 10:34, Pawel Osciak wrote:
> On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>> From: Hans Verkuil <hansverk@xxxxxxxxx>
>>
>> Add support for DMABUF exporting to the vb2-vmalloc implementation.
>>
>> All memory models now have support for both importing and exporting of DMABUFs.
>> Signed-off-by: Hans Verkuil <hansverk@xxxxxxxxx>
>> ---
>>  drivers/media/v4l2-core/videobuf2-vmalloc.c | 174 ++++++++++++++++++++++++++++
>>  1 file changed, 174 insertions(+)
>>
>> diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c
>> index bba2460..dfbb6d5 100644
>> --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c
>> +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c
>> @@ -31,6 +31,9 @@ struct vb2_vmalloc_buf {
>>         atomic_t                        refcount;
>>         struct vb2_vmarea_handler       handler;
>>         struct dma_buf                  *dbuf;
>> +
>> +       /* DMABUF related */
>> +       struct dma_buf_attachment       *db_attach;
> 
> Unused?
> 

Indeed. There is no device to be attached to this buffer, so this
copy-and-paste field can be removed.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux