Hi Marina, On Mon, Nov 10, 2014 at 10:11:31AM +0200, Marina Vasilevsky wrote: > --- > drivers/staging/media/omap4iss/iss_csiphy.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/iss_csiphy.c > b/drivers/staging/media/omap4iss/iss_csiphy.c > index 7c3d55d..b6e0b32 100644 > --- a/drivers/staging/media/omap4iss/iss_csiphy.c > +++ b/drivers/staging/media/omap4iss/iss_csiphy.c > @@ -196,8 +196,7 @@ int omap4iss_csiphy_config(struct iss_device *iss, > return -EINVAL; > > csi2_ddrclk_khz = pipe->external_rate / 1000 > - / (2 * csi2->phy->used_data_lanes) > - * pipe->external_bpp; > + / 2 * pipe->external_bpp; > > /* > * THS_TERM: Programmed value = ceil(12.5 ns/DDRClk period) - 1. > -- > > Hello, > > I tested this fix with OMAP4 connected to OV5640 camera using 2 lanes. > Have anybody tested other camera with 2 lanes connected to OMAP? > > The value csi2_ddrclk_khz is different per camera. > I have also driver for OV7695. Current iss params structure does not > allow to configure it properly from board file. Are you certain the pixel rate value provided by the sensor driver is correct? The formula in iss_csiphy.c is fine as far as I understand. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
