On Sat, Nov 8, 2014 at 7:20 PM, Pawel Osciak <pawel@xxxxxxxxxx> wrote: > Hi Hans, > Thank you for the patch. > > On Fri, Nov 7, 2014 at 5:50 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> Add support for dmabuf to vb2-dma-sg. > > importing dmabuf into videobuf2-dma-sg. > One thing I missed in the review, I think vb2_dma_sg_vaddr() needs to be updated in this patch to take into account that we may have an attachment present, just like it's done in dma-contig, i.e. if !vaddr and attachment present, call the dma_buf_vmap() dmabuf op instead of vm_map_ram. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
