Hi Hans, Thank you for the patch. On Fri, Nov 7, 2014 at 5:50 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > This moves dma_(un)map_sg to the get_userptr/put_userptr and alloc/put > memops of videobuf2-dma-sg.c and adds dma_sync_sg_for_device/cpu to the > prepare/finish memops. > > Now that vb2-dma-sg will sync the buffers for you in the prepare/finish > memops we can drop that from the drivers that use dma-sg. > > For the solo6x10 driver that was a bit more involved because it needs to > copy JPEG or MPEG headers to the buffer before returning it to userspace, > and that cannot be done in the old place since the buffer there is still > setup for DMA access, not for CPU access. However, the buf_finish > op is the ideal place to do this. By the time buf_finish is called > the buffer is available for CPU access, so copying to the buffer is fine. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Acked-by: Pawel Osciak <pawel@xxxxxxxxxx> -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html