On 31.10.2014 11:32, Mauro Carvalho Chehab wrote: > Em Thu, 30 Oct 2014 23:43:55 +0100 > Matthias Schwarzott <zzam@xxxxxxxxxx> escreveu: > >> The only remaining place that modifies the relevant bit is in function >> cx231xx_set_Colibri_For_LowIF >> >> Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx> >> --- >> drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c >> index b56bc87..781908b 100644 >> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c >> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c >> @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) >> case POLARIS_AVMODE_ANALOGT_TV: >> >> tmp |= PWR_DEMOD_EN; >> - tmp |= (I2C_DEMOD_EN); >> value[0] = (u8) tmp; >> value[1] = (u8) (tmp >> 8); >> value[2] = (u8) (tmp >> 16); >> @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) >> } >> >> tmp &= (~PWR_AV_MODE); >> - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; >> + tmp |= POLARIS_AVMODE_DIGITAL; >> value[0] = (u8) tmp; >> value[1] = (u8) (tmp >> 8); >> value[2] = (u8) (tmp >> 16); > Hi Mauro, > Hmm... Not sure if this patch is right. There is one I2C bus internally > at cx231xx. Some configurations need to go through this I2C bus. > What exactly do you mean by configurations need to go through this I2C bus? Do you mean the port3 switch must have a specific value even when not doing i2c transfers? > Did you test if changing from/to analog/digital mode is working? > I did not yet check analog mode. Regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
