On Thu, Oct 30, 2014 at 3:52 PM, Michael Ira Krufky <mkrufky@xxxxxxxxxxx> wrote: > On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxxxxxxx> wrote: >> Hi Devin, >> >> Em Thu, 30 Oct 2014 09:15:31 -0400 >> Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu: >> >>> Hi Mauro, >>> >>> > Syncronize it and put them on the same order as found at au0828 >>> > driver, as all the au0828 devices with analog TV need the >>> > same quirks. >>> >>> The MXL and Woodbury boards don't support analog under Linux, so >>> probably shouldn't be included in the list of quirks. >> >> True. >>> >>> That said, the MXL and Woodbury versions of the PCBs were prototypes >>> that never made it into production (and since the Auvitek chips are >>> EOL, they never will). I wouldn't object to a patch which removed the >>> board profiles entirely in the interest of removing dead code. >>> >>> It was certainly nice of Mike Krufky to work to get support into the >>> open source driver before the product was released, but after four >>> years it probably makes sense to remove the entries for products that >>> never actually shipped. >> >> Yeah, if nobody is using such devices, then we should get rid of them, >> but I prefer to have this on a separate patch, in order to give >> people the opportunity to complain. >> >> So, if I'm understanding well, you're suggesting to add a patch >> removing those 5 entries (and the corresponding quirks on alsa), >> right? >> >> { USB_DEVICE(0x2040, 0x7201), >> .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL }, >> { USB_DEVICE(0x2040, 0x7211), >> .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL }, >> { USB_DEVICE(0x2040, 0x7281), >> .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL }, >> { USB_DEVICE(0x05e1, 0x0480), >> .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, >> { USB_DEVICE(0x2040, 0x8200), >> .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, >> { USB_DEVICE(0x2040, 0x7260), >> >> Regards, >> Mauro >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Let's *not* remove DTV support for WOODBURY board -- it is not the > business of the public whether or not the board shipped in > mass-production. The board profile is in fact being used for some > reference designs, and I still use my woodbury prototype to test the > MXL tuner. > > I am not the only person using this profile -- no not remove it, please. correction: I still use both the woodbury prototype (to test the reference design) *and* the MXL version for testing the mxl tuner. There is no reason to remove these profiles, the USB IDs will not be recycled -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html