Hi Kaneko-san,
On Tue, Oct 21, 2014 at 5:30 AM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>>> --- a/drivers/media/platform/soc_camera/rcar_vin.c
>>> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
>>> @@ -108,6 +108,7 @@
>>> #define VNDMR2_VPS (1 << 30)
>>> #define VNDMR2_HPS (1 << 29)
>>> #define VNDMR2_FTEV (1 << 17)
>>> +#define VNDMR2_VLV_1 (1 << 12)
>>
>> Please instead do:
>>
>> #define VNDMR2_VLV(n) ((n & 0xf) << 12)
>
> It's unclear to me why the style of the new #define should differ
> from those of the existing ones.
I think Sergey wants to say that unlike for the other fields, there are
multiple possible values for the VLV field.
By providing the single macro definition
#define VNDMR2_VLV(n) ((n & 0xf) << 12)
you can easily provide a way to set any of VNDMR2_VLV_n.
I hope this explanation makes it clearer.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
