Hello Sergei, Thank you for your comments. 2014-10-19 0:01 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > Hello. > > On 10/14/2014 10:25 AM, Yoshihiro Kaneko wrote: > >> From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> > > >> By applying this patch, it sets to VSYNC field toggle mode not only >> at the time of progressive mode but at the time of an interlace mode. > > >> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> >> --- > > >> This patch is against master branch of linuxtv.org/media_tree.git. > > >> drivers/media/platform/soc_camera/rcar_vin.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > >> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c >> b/drivers/media/platform/soc_camera/rcar_vin.c >> index 5196c81..bf97ed6 100644 >> --- a/drivers/media/platform/soc_camera/rcar_vin.c >> +++ b/drivers/media/platform/soc_camera/rcar_vin.c >> @@ -108,6 +108,7 @@ >> #define VNDMR2_VPS (1 << 30) >> #define VNDMR2_HPS (1 << 29) >> #define VNDMR2_FTEV (1 << 17) >> +#define VNDMR2_VLV_1 (1 << 12) > > > Please instead do: > > #define VNDMR2_VLV(n) ((n & 0xf) << 12) It's unclear to me why the style of the new #define should differ from those of the existing ones. Thanks, Kaneko > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
