Re: [PATCH] Add patch to allow compilation on versions < 3.5 with CONFIG_OF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Doesn't this produce compiler warnings since the static v4l2_of_parse_*
> functions are now never called?

Those functions are inside the "#if 0", so the compiler never sees them.

> I would patch v4l2-core/Makefile instead to just never compile v4l2-of.o.

Because the final Makefile is generated by a script, I didn't think
you actually could address it at the "make prepare" phase.  That said,
now I see that I could have patched
linux/drivers/media/vl2-core/Makefile as you suggested.

I don't have time to regenerate/resubmit at this point.  Take the
patch if you want it, feel free to recreate the patch slightly
differently with no discernible benefit, or eventually I will get
around to it the next time I'm working on that tree.

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux