On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: > On 06/06/2014 11:46 AM, Laurent Pinchart wrote: > > On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: > >> On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > >>> On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > >>>> Hi Laurent, > >>>> Thanks for the patch. Did you test this to work in fileio mode? Looks > >>>> like it should, but would like to make sure. > >>> > >>> No, I haven't tested it. The OMAP4 ISS driver, which is my test target > >>> for this patch, doesn't support fileio mode. Adding VB2_READ would be > >>> easy, but the driver requires configuring the format on the file handle > >>> used for streaming, so I can't just run cat /dev/video*. > >> > >> Just test with vivi. > > > > But vivi doesn't call the new vb2_queue_error() function. I understand > > that your vivi rework would make that easier as you now have an error > > control. Should I hack something similar in the existing vivi driver ? Any > > pointer ? > > Just hack it in for testing. E.g. call it when the button control is pressed > (see vivi_s_ctrl). Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> "cat /dev/video0" outputs data until vivi calls vb2_queue_error(), at which points cat prints cat: /dev/video0: Input/output error Restarting capture works as expected. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
