Hi Hans, On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: > On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > > Hi Pawel, > > > > On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > >> Hi Laurent, > >> Thanks for the patch. Did you test this to work in fileio mode? Looks > >> like it should, but would like to make sure. > > > > No, I haven't tested it. The OMAP4 ISS driver, which is my test target for > > this patch, doesn't support fileio mode. Adding VB2_READ would be easy, > > but the driver requires configuring the format on the file handle used for > > streaming, so I can't just run cat /dev/video*. > > Just test with vivi. But vivi doesn't call the new vb2_queue_error() function. I understand that your vivi rework would make that easier as you now have an error control. Should I hack something similar in the existing vivi driver ? Any pointer ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html