Hi Hans, Thank you for the patches. On Monday 17 February 2014 12:44:11 Hans Verkuil wrote: > This patch series addresses a problem that was exposed by commit a5338190e. > The issue is that soc_camera implements s/g_std ioctls and just forwards > those to the subdev, whether or not the subdev actually implements them. > > In addition, tvnorms is never set, so even if the subdev implements the > s/g_std the ENUMSTD ioctl will not report anything. > > The solution is to add a g_tvnorms video op to v4l2_subdev (there was > already a g_tvnorms_output, so that fits nicely) and to let soc_camera call > that so the video_device tvnorms field is set correctly. > > Before registering the video node it will check if tvnorms == 0 and disable > the STD ioctls if that's the case. > > While this problem cropped up in soc_camera it is really a problem for any > generic bridge driver, so this is useful to have. > > Note that it is untested. The plan is that Laurent tests and Guennadi pulls > it into his tree. I've tested the series on v3.10 with the atmel-isi driver. Without the patches applied ENUMSTD returns -ENODATA, and with the patches applied it returns - ENOTTY. Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
