Re: [PATCH] media: v4l2-dev: fix video device index assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Ricardo Ribalda <ricardo.ribalda@xxxxxxxxx>

On Tue, Dec 3, 2013 at 2:23 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> Hi, Marek!
>
> Thanks for the patch.
>
> On Tue, Dec 03, 2013 at 02:14:29PM +0100, Marek Szyprowski wrote:
>> The side effect of commit 1056e4388b045 ("v4l2-dev: Fix race condition on
>> __video_register_device") is the increased number of index value assigned
>> on video_device registration. Before that commit video_devices were
>> numbered from 0, after it, the indexes starts from 1, because get_index()
>> always count the device, which is being registered. Some device drivers
>> rely on video_device index number for internal purposes, i.e. s5p-mfc
>> driver stopped working after that patch. This patch restores the old method
>> of numbering the video_device indexes.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>> ---
>> In my opinion this patch should be applied also to stable v3.12 series.
>
> I agree.
>
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>
> --
> Cheers,
>
> Sakari Ailus
> e-mail: sakari.ailus@xxxxxx     XMPP: sailus@xxxxxxxxxxxxxx



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux