Re: [Review Patch 0/9] si4713 usb device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 4, 2013 at 10:21 AM, d ram <dinesh.ram086@xxxxxxxxx> wrote:
> Hearty congratulations Eduardo !

Thanks,

> Btw...I didnt get any compilation error for the patch sent by Hans.
> Are you using the trunk version of the kernel?

I've just reset to v3.12 tag. The issue is actually produced by the
patch itself as it moves the macro definition, but still uses it in
the board file.

>
>
> On Mon, Nov 4, 2013 at 3:13 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>>
>> On 11/04/2013 03:09 PM, edubezval@xxxxxxxxx wrote:
>> > Hans,
>> >
>> > On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>> >> On 10/15/2013 07:37 PM, edubezval@xxxxxxxxx wrote:
>> >>> Hello Dinesh,
>> >>>
>> >>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram <dinesh.ram@xxxxxxx>
>> >>> wrote:
>> >>>> Hello Eduardo,
>> >>>>
>> >>>> In this patch series, I have addressed the comments by you
>> >>>> concerning my last patch series.
>> >>>> In the resulting patches, I have corrected most of the
>> >>>> style issues and adding of comments. However, some warnings
>> >>>> given out by checkpatch.pl (mostly complaing about lines longer
>> >>>> than 80 characters) are still there because I saw that code
>> >>>> readibility
>> >>>> suffers by breaking up those lines.
>> >>>>
>> >>>> Also Hans has contributed patches 8 and 9 in this patch series
>> >>>> which address the issues of the handling of unknown regulators,
>> >>>> which have apparently changed since 3.10. Hans has tested it and the
>> >>>> driver loads again.
>> >>>>
>> >>>> Let me know when you are able to test it again.
>> >>>>
>> >>>
>> >>> Hopefully I will be able to give it a shot on n900 and on silabs
>> >>> devboard until the end of the week. Thanks for not giving up.
>> >>
>> >> Did you find time to do this? I'm waiting for feedback from you.
>> >
>> > sorry for the late answer, I was offline for two weeks taking care of
>> > my newborn  son :-).
>>
>> An excellent reason! Congratulations!
>>
>>         Hans
>>
>> >
>> > I am giving the series a second shot.
>> >
>> >>
>> >> Regards,
>> >>
>> >>         Hans
>> >
>> >
>> >
>>
>



-- 
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux