Am 10.10.2013 20:38, schrieb Frank Schäfer: [...] >>>> "Hmm... your patch didn't change this, but: >>>> Why do we call these functions only in case of V4L2_BUF_TYPE_VIDEO_CAPTURE ? >>>> Isn't it needed for VBI capturing, too ? >>>> em28xx_wake_i2c() is probably also needed for radio mode..." >>>> >>>> Right, my patch doesn't change this, so, this is unrelated. >>> Ok, I have to admit that I wasn't clear enough in this case: >>> IMHO these are bugs that should be fixed, but I'm not 100% sure. >>> In that case, there is no need to split the if-caluse containing the >>> V4L2_BUF_TYPE_VIDEO_CAPTURE check, just remove this check while you're >>> at it. >> No! It shouldn't be changed "while at it." If it should be changed, it >> _certainly_ has to be a separate patch! And it is unrelated. > If you want the fix as a separate patch, then it would make sense to do > this before the s_power change. > IMHO it doesn't make sense to complicate the code just to keep a bug > which can be fixed easily. Looking into the code again, I think there are even more things which need to be fixed. :( Will try to send a patch tomorrow. Regards, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
