Hi Frank, On Tue, 8 Oct 2013, Frank SchÀfer wrote: > Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab: > > Em Sun, 18 Aug 2013 13:40:25 +0200 > > Frank SchÀfer <fschaefer.oss@xxxxxxxxxxxxxx> escreveu: > > > >> Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski: > >>> Hi Frank, > >>> As I mentioned on the list, I'm currently on a holiday, so, replying briefly. > >> Sorry, I missed that (can't read all mails on the list). > >> > >>> Since em28xx is a USB device, I conclude, that it's supplying clock to its components including the ov2640 sensor. So, yes, I think the driver should export a V4L2 clock. > >> Ok, so it's mandatory on purpose ? > >> I'll take a deeper into the v4l2-clk code and the > >> em28xx/ov2640/soc-camera interaction this week. > >> Have a nice holiday ! > > commit 9aea470b399d797e88be08985c489855759c6c60 > > Author: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > Date: Fri Dec 21 13:01:55 2012 -0300 > > > > [media] soc-camera: switch I2C subdevice drivers to use v4l2-clk > > > > Instead of centrally enabling and disabling subdevice master clocks in > > soc-camera core, let subdevice drivers do that themselves, using the > > V4L2 clock API and soc-camera convenience wrappers. > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > > > > > > (c/c the ones that acked with this broken changeset) > > > > We need to fix it ASAP or to revert the ov2640 changes, as some em28xx > > cameras are currently broken on 3.10. > > > > I'll also reject other ports to the async API if the drivers are > > used outside an embedded driver, as no PC driver currently defines > > any clock source. The same applies to regulators. > > > > Guennadi, > > > > Next time, please check if the i2c drivers are used outside soc_camera > > and apply the fixes where needed, as no regressions are allowed. > > > > Regards, > > Mauro > > FYI: 8 weeks have passed by now and this regression has still not been > fixed. > Does anybody care about it ? WONTFIX ? You replied to my patch "em28xx: balance subdevice power-off calls" with a few non-essential IMHO comments but you didn't test it. Could you test, please? In the meantime I'm still waiting for more comments to my "[RFD] use-counting V4L2 clocks" mail, so far only Sylwester has replied. Without all these we don't seem to progress very well. Thanks Guennadi > >>> -----Original Message----- > >>> From: "Frank SchÀfer" <fschaefer.oss@xxxxxxxxxxxxxx> > >>> To: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>, Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx> > >>> Sent: Fr., 16 Aug 2013 21:03 > >>> Subject: em28xx + ov2640 and v4l2-clk > >>> > >>> Hi Guennadi, > >>> > >>> since commit 9aea470b399d797e88be08985c489855759c6c60 "soc-camera: > >>> switch I2C subdevice drivers to use v4l2-clk", the em28xx driver fails > >>> to register the ov2640 subdevice (if needed). > >>> The reason is that v4l2_clk_get() fails in ov2640_probe(). > >>> Does the em28xx driver have to register a (pseudo ?) clock first ? > >>> > >>> Regards, > >>> Frank --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
