Hi Wei, On Fri, Aug 23, 2013 at 8:50 AM, Prabhakar Lad <prabhakar.csengg@xxxxxxxxx> wrote: > Hi Wei, > > I retract my Ack. > > On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote: >> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> >> >> Fix to return -ENODEV in the subdevice register error handling >> case instead of 0, as done elsewhere in this function. >> >> Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba >> ([media] media: davinci: vpif: capture: add V4L2-async support) >> >> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> >> --- >> drivers/media/platform/davinci/vpif_capture.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c >> index 7fbde6d..e4b6a26 100644 >> --- a/drivers/media/platform/davinci/vpif_capture.c >> +++ b/drivers/media/platform/davinci/vpif_capture.c >> @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) >> >> if (!vpif_obj.sd[i]) { >> vpif_err("Error registering v4l2 subdevice\n"); >> + err = -ENOMEM; > > This should be err = -ENODEV > I assume you will fix it and repost this patch. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html