On Monday 26 August 2013 12:53:46 Sakari Ailus wrote:
> On Mon, Aug 26, 2013 at 11:17:51AM +0200, Laurent Pinchart wrote:
> > The helper function is defined by a macro that is erroneously called
> > with the compose rectangle instead of the crop rectangle. Fix it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >
> > include/media/v4l2-subdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index bfda0fe..34d9219 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -628,7 +628,7 @@ struct v4l2_subdev_fh {
> >
> > }
> >
> > __V4L2_SUBDEV_MK_GET_TRY(v4l2_mbus_framefmt, format, try_fmt)
> > -__V4L2_SUBDEV_MK_GET_TRY(v4l2_rect, crop, try_compose)
> > +__V4L2_SUBDEV_MK_GET_TRY(v4l2_rect, crop, try_crop)
> > __V4L2_SUBDEV_MK_GET_TRY(v4l2_rect, compose, try_compose)
> > #endif
>
> Oops. My bad I guess... it's a surprise to me this one slipped through.
> Excellent find!
>
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxx>
Thank you.
Mauro, could you please pick this patch up, for v3.12 if still possible ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
