Re: [PATCH 2/3] [media] exynos4-is: Annotate unused functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester,

On 5 August 2013 16:35, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
> Hi Sachin,
>
> On 08/05/2013 07:12 AM, Sachin Kamat wrote:
>> On 2 August 2013 12:02, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
>>> > __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
>>> > any callers. However these functions may be used in the future. Hence
>>> > instead of deleting them, staticize and annotate them with __maybe_unused
>>> > flag to avoid compiler warnings.
>>> >
>>> > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> Thanks for applying the other 2 patches in this series. What is your
>> opinion about this one?
>> Does this look good or do you prefer to delete the code altogether?
>
> Thanks for your work on this. I think it would be better to call those
> functions somewhere instead, e.g. in the fimc-is initialization routine,
> until there is a user interface available for this 3A control.
> fimc_is_hw_set_tune() just needs a private control a think. Let me see
> if I can come up with at least some intermediate patch to achieve this,
> so the warnings can be eliminated. I wouldn't like to take such steps
> backwards, marking those functions static an unused.

Marking it unused is just a stop gap solution to silence unnecessary warnings.
However if you can come up with some users for these functions, then
that would be great
and right thing to do.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux