Hi Sylwester,
On 2 August 2013 12:02, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
> any callers. However these functions may be used in the future. Hence
> instead of deleting them, staticize and annotate them with __maybe_unused
> flag to avoid compiler warnings.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Thanks for applying the other 2 patches in this series. What is your
opinion about this one?
Does this look good or do you prefer to delete the code altogether?
> ---
> drivers/media/platform/exynos4-is/fimc-is-param.c | 2 +-
> drivers/media/platform/exynos4-is/fimc-is-regs.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/exynos4-is/fimc-is-param.c b/drivers/media/platform/exynos4-is/fimc-is-param.c
> index a353be0..9bf3ddd 100644
> --- a/drivers/media/platform/exynos4-is/fimc-is-param.c
> +++ b/drivers/media/platform/exynos4-is/fimc-is-param.c
> @@ -287,7 +287,7 @@ void __is_set_sensor(struct fimc_is *is, int fps)
> fimc_is_set_param_bit(is, PARAM_ISP_OTF_INPUT);
> }
>
> -void __is_set_init_isp_aa(struct fimc_is *is)
> +static void __maybe_unused __is_set_init_isp_aa(struct fimc_is *is)
> {
> struct isp_param *isp;
>
> diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c b/drivers/media/platform/exynos4-is/fimc-is-regs.c
> index 63c68ec..cf2e13a 100644
> --- a/drivers/media/platform/exynos4-is/fimc-is-regs.c
> +++ b/drivers/media/platform/exynos4-is/fimc-is-regs.c
> @@ -96,7 +96,7 @@ int fimc_is_hw_set_param(struct fimc_is *is)
> return 0;
> }
>
> -int fimc_is_hw_set_tune(struct fimc_is *is)
> +static int __maybe_unused fimc_is_hw_set_tune(struct fimc_is *is)
> {
> fimc_is_hw_wait_intmsr0_intmsd0(is);
>
> --
> 1.7.9.5
>
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
